From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbcHGPsy (ORCPT ); Sun, 7 Aug 2016 11:48:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:46813 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcHGPsx (ORCPT ); Sun, 7 Aug 2016 11:48:53 -0400 Date: Sun, 7 Aug 2016 17:48:49 +0200 From: Jean Delvare To: Joe Perches Cc: LKML , Andrew Morton Subject: Re: [PATCH] scripts/Lindent: clean up and optimize Message-ID: <20160807174849.1e30bef7@endymion> In-Reply-To: <1470419599.28648.7.camel@perches.com> References: <20160805112618.6c43997f@endymion> <1470419599.28648.7.camel@perches.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.30; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote: > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > > * Add a few blank lines to improve readability. > > * Don't call cut 3 times when once is enough. > > * Drop a useless semicolon. > > As it commonly reflows > 80 column code very badly, > my preference would be to remove Lindent instead. > > https://lkml.org/lkml/2013/2/11/390 This was 3.5 years ago, so apparently it's not happening. Why don't you just remove -l80 from the options, if this is your only concern with the script? Adding the appropriate option to indent to support what we think is good would seem even better, but I do not have any time to devote to this task. -- Jean Delvare SUSE L3 Support