[PATCH] scripts/Lindent: clean up and optimize

[PATCH] scripts/Lindent: clean up and optimize

[Jean Delvare]

* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
 scripts/Lindent |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

--- linux-4.7.orig/scripts/Lindent	2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/scripts/Lindent	2016-08-05 11:09:37.896577373 +0200
@@ -1,21 +1,25 @@
 #!/bin/sh
+
 PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
-RES=`indent --version`
+
+RES=`indent --version | cut -d' ' -f3`
 if [ "$RES" = "" ]; then
 	exit 1
 fi
-V1=`echo $RES | cut -d' ' -f3 | cut -d'.' -f1`
-V2=`echo $RES | cut -d' ' -f3 | cut -d'.' -f2`
-V3=`echo $RES | cut -d' ' -f3 | cut -d'.' -f3`
+V1=`echo $RES | cut -d'.' -f1`
+V2=`echo $RES | cut -d'.' -f2`
+V3=`echo $RES | cut -d'.' -f3`
+
 if [ $V1 -gt 2 ]; then
   PARAM="$PARAM -il0"
 elif [ $V1 -eq 2 ]; then
   if [ $V2 -gt 2 ]; then
-    PARAM="$PARAM -il0";
+    PARAM="$PARAM -il0"
   elif [ $V2 -eq 2 ]; then
     if [ $V3 -ge 10 ]; then
       PARAM="$PARAM -il0"
     fi
   fi
 fi
+
 indent $PARAM "$@"


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] scripts/Lindent: clean up and optimize

[Joe Perches]

On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> * Add a few blank lines to improve readability.
> * Don't call cut 3 times when once is enough.
> * Drop a useless semicolon.

As it commonly reflows > 80 column code very badly,
my preference would be to remove Lindent instead.

https://lkml.org/lkml/2013/2/11/390

Re: [PATCH] scripts/Lindent: clean up and optimize

[Jean Delvare]

Hi Joe,

On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > * Add a few blank lines to improve readability.
> > * Don't call cut 3 times when once is enough.
> > * Drop a useless semicolon.
> 
> As it commonly reflows > 80 column code very badly,
> my preference would be to remove Lindent instead.
> 
> https://lkml.org/lkml/2013/2/11/390

This was 3.5 years ago, so apparently it's not happening.

Why don't you just remove -l80 from the options, if this is your only
concern with the script? Adding the appropriate option to indent to
support what we think is good would seem even better, but I do not have
any time to devote to this task.

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] scripts/Lindent: clean up and optimize

[Joe Perches]

On Sun, 2016-08-07 at 17:48 +0200, Jean Delvare wrote:
> Hi Joe,
> 
> On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> > 
> > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > > 
> > > * Add a few blank lines to improve readability.
> > > * Don't call cut 3 times when once is enough.
> > > * Drop a useless semicolon.
> > As it commonly reflows > 80 column code very badly,
> > my preference would be to remove Lindent instead.
> > 
> > https://lkml.org/lkml/2013/2/11/390
> This was 3.5 years ago, so apparently it's not happening.
>
> Why don't you just remove -l80 from the options, if this is your only
> concern with the script?

line length is not context aware and you'd get > 256
column lines in a lot of cases.

>  Adding the appropriate option to indent to
> support what we think is good would seem even better, but I do not have
> any time to devote to this task.

Nor does anyone else.
indent has had 1 change in 14 years.

clang-format might be a better tool and a better
suggestion than Lindent now.