From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752117AbcHHHIj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Aug 2016 03:08:39 -0400
Received: from mail.kernel.org ([198.145.29.136]:60476 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750846AbcHHHIh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Aug 2016 03:08:37 -0400
Date: Mon, 8 Aug 2016 15:08:03 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: andrej@inversepath.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Vagrant Cascadian <vagrant@debian.org>,
        linux-arm-kernel@lists.infradead.org,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: imx53: add support for USB armory board
Message-ID: <20160808070803.GB4678@tiger>
References: <20160628125444.16531-1-andrej@inversepath.com>
 <20160628125444.16531-3-andrej@inversepath.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160628125444.16531-3-andrej@inversepath.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

One more comment below.

On Tue, Jun 28, 2016 at 02:54:44PM +0200, andrej@inversepath.com wrote:
> +&iomuxc {
> +	pinctrl_esdhc1: esdhc1grp {
> +		fsl,pins = <
> +			MX53_PAD_SD1_DATA0__ESDHC1_DAT0		0x1d5
> +			MX53_PAD_SD1_DATA1__ESDHC1_DAT1		0x1d5
> +			MX53_PAD_SD1_DATA2__ESDHC1_DAT2		0x1d5
> +			MX53_PAD_SD1_DATA3__ESDHC1_DAT3		0x1d5
> +			MX53_PAD_SD1_CMD__ESDHC1_CMD		0x1d5
> +			MX53_PAD_SD1_CLK__ESDHC1_CLK		0x1d5
> +		>;
> +	};
> +
> +	pinctrl_i2c1_pmic: i2c1grp_pmic {
> +		fsl,pins = <
> +			MX53_PAD_EIM_D21__I2C1_SCL	0x0
> +			MX53_PAD_EIM_D28__I2C1_SDA	0x0

Please use a proper pin configuration value rather than 0x0.

> +		>;
> +	};
> +
> +	pinctrl_led: led {
> +		fsl,pins = <
> +			MX53_PAD_DISP0_DAT6__GPIO4_27 0x0

Ditto.

Shawn

> +		>;
> +	};