From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Bernd Petrovitsch <bernd@sysprog.at>
Cc: <lee.jones@linaro.org>, <patches@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: arizona: Remove pointless switch case
Date: Mon, 8 Aug 2016 09:09:24 +0100 [thread overview]
Message-ID: <20160808080924.GA21682@localhost.localdomain> (raw)
In-Reply-To: <1469295673.14838.4.camel@sysprog.at>
On Sat, Jul 23, 2016 at 07:41:13PM +0200, Bernd Petrovitsch wrote:
> Hi all!
>
> On Fri, 2016-07-22 at 16:58 +0100, Charles Keepax wrote:
> [...]
> > case IRQF_TRIGGER_RISING:
> > case IRQF_TRIGGER_FALLING:
> > break;
> > -
> > - case IRQ_TYPE_NONE:
> > default:
>
> Don't know about the kernels coding rule in that case but personally, I
> use that style to explicit list all enum/#define values so that it is
> obvious that none was forgotten.
> For the compiler output, it shouldn't matter anyways ...
>
I don't have any objection to dropping the patch as you say will
generate the same output either way.
Thanks,
Charles
prev parent reply other threads:[~2016-08-08 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 15:58 [PATCH] mfd: arizona: Remove pointless switch case Charles Keepax
2016-07-23 17:41 ` Bernd Petrovitsch
2016-08-08 8:09 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808080924.GA21682@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=bernd@sysprog.at \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox