From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752297AbcHHJkd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Aug 2016 05:40:33 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:33216 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751320AbcHHJkc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Aug 2016 05:40:32 -0400
Date: Mon, 8 Aug 2016 11:40:27 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: David Binderman <linuxdev.baldrick@gmail.com>
Cc: daniel.vetter@intel.com, jani.nikula@linux.intel.com,
        David Airlie <airlied@linux.ie>, dcb314@hotmail.com,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ?
Message-ID: <20160808094027.GA6232@phenom.ffwll.local>
Mail-Followup-To: David Binderman <linuxdev.baldrick@gmail.com>,
	daniel.vetter@intel.com, jani.nikula@linux.intel.com,
	David Airlie <airlied@linux.ie>, dcb314@hotmail.com,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAMzoamaAMS7_Oj65hbsmC4Xfsoh6Q2mLz7dL=gWe56S+=-KmBA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMzoamaAMS7_Oj65hbsmC4Xfsoh6Q2mLz7dL=gWe56S+=-KmBA@mail.gmail.com>
X-Operating-System: Linux phenom 4.6.0-1-amd64 
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 08, 2016 at 10:31:32AM +0100, David Binderman wrote:
> Hello there,
> 
> Recent versions of gcc say this:
> 
> include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’
> requires 37 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
> 
> Source code is
> 
> #define   INTEL_BSM_MASK (0xFFFF << 20)
> 
> Maybe something like
> 
> #define   INTEL_BSM_MASK (0xFFFFUL<< 20)
> 
> might be better.

Yup. Care to bake this into a patch (with s-o-b and everything per
Documentation/SubmittingPatches) so I can apply it?
-Daniel

> 
> 
> Regards
> 
> David Binderman
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch