public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Sheng-Hui J. Chu" <s.jeffrey.chu@gmail.com>
Cc: linux-usb@vger.kernel.org, johan@kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
Date: Mon, 8 Aug 2016 12:28:34 +0200	[thread overview]
Message-ID: <20160808102834.GC10523@localhost> (raw)
In-Reply-To: <032a01d1e913$425badd0$c7130970$@gmail.com>

On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
> 
> To support BCM920706V2_EVAL dev board for WICED development on Linux.  Add the VID(0a5c) and 
> PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
> 
> Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
> ---
>  drivers/usb/serial/ftdi_sio.c	   | 1 +
>  drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> +	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
> 	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
>  #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
>  #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
>  #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * WICED USB UART
> + */
> +#define WICED_USB_VID		0x0A5C
> +#define WICED_USB20706V2_PID	0x6422

This patch still failed to apply:

Applying: usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
fatal: corrupt patch at line 11
Patch failed at 0001 usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

and checkpatch also complained about possible line wrapping.

I fixed it up here before applying, but next time please try sending the
patch to yourself and make sure it still applies before posting to the
list.

Thanks,
Johan

      parent reply	other threads:[~2016-08-08 10:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 21:01 [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board Sheng-Hui J. Chu
2016-07-28 21:09 ` Greg KH
2016-07-28 21:22   ` Sheng-Hui J. Chu
2016-08-08 10:28 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160808102834.GC10523@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=s.jeffrey.chu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox