From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbcHHLQV (ORCPT ); Mon, 8 Aug 2016 07:16:21 -0400 Received: from mga14.intel.com ([192.55.52.115]:63030 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752374AbcHHLQP (ORCPT ); Mon, 8 Aug 2016 07:16:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,489,1464678000"; d="scan'208";a="1021580766" Date: Mon, 8 Aug 2016 14:16:07 +0300 From: Jarkko Sakkinen To: Baole Ni Cc: peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, hpa@zytor.com, x86@kernel.org, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, jslaby@suse.cz, peter@korsgaard.com, lee.jones@linaro.org Subject: Re: [PATCH 0111/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160808111607.GA19346@intel.com> References: <20160802104129.21155-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802104129.21155-1-baolex.ni@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 06:41:29PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni I choose to ignore this and other similar patches you have submitted for the TPM driver subsystem. /Jarkko