From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbcHHOFB (ORCPT ); Mon, 8 Aug 2016 10:05:01 -0400 Received: from merlin.infradead.org ([205.233.59.134]:56366 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752313AbcHHOE7 (ORCPT ); Mon, 8 Aug 2016 10:04:59 -0400 Date: Mon, 8 Aug 2016 16:04:51 +0200 From: Peter Zijlstra To: Tommaso Cucinotta Cc: Luca Abeni , Juri Lelli , Ingo Molnar , linux-kernel@vger.kernel.org, linux-dl@retis.sssup.it, Juri Lelli Subject: Re: [RFC PATCH 3/4] Make deadline max-heap faster avoiding real swaps on heapify ops. Message-ID: <20160808140451.GG6879@twins.programming.kicks-ass.net> References: <1468921493-10054-1-git-send-email-tommaso.cucinotta@sssup.it> <1468921493-10054-4-git-send-email-tommaso.cucinotta@sssup.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468921493-10054-4-git-send-email-tommaso.cucinotta@sssup.it> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 11:44:52AM +0200, Tommaso Cucinotta wrote: > This change achieves up to 10% of speed-up for cpudl_set() calls, as > measured with a andomly generated workload of 1K,10K,100K random heap > insertions and deletions (75% cpudl_set() calls with is_valid=1 and > 25% with is_valid=0), and randomly generated cpu IDs, with up to 256 > CPUs, as measured on an Intel Core2 Duo. Changelog fails to explain _what_ the change is. Some details on the change in implementation and why this is faster would be good.