From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbcHHU2F (ORCPT ); Mon, 8 Aug 2016 16:28:05 -0400 Received: from mga14.intel.com ([192.55.52.115]:27576 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbcHHU2D (ORCPT ); Mon, 8 Aug 2016 16:28:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,491,1464678000"; d="scan'208";a="152571782" Date: Mon, 8 Aug 2016 23:27:58 +0300 From: Jarkko Sakkinen To: Peter Huewe Cc: linux-security-module@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: fix build error Message-ID: <20160808202758.GA32391@intel.com> References: <1470687926-32267-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470687926-32267-1-git-send-email-jarkko.sakkinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As the fix is quite trivial I already pushed this fixup on tip of my master branch in order to make testing easy. /Jarkko On Mon, Aug 08, 2016 at 11:25:26PM +0300, Jarkko Sakkinen wrote: > tpm_getcap and tpm2_get_tpm_pt were not properly exported. This commit > adds the exports. The build error exist only in the master (bleeding > edge) branch so this problem does not concern 4.8 release. > > The commit will be folded to 4d970e733b09 as soon as it is tested and > reviewed. > > Fixes: 4d970e733b09 > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm-interface.c | 1 + > drivers/char/tpm/tpm2-cmd.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index ef5ad80..43ef0ef 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -458,6 +458,7 @@ ssize_t tpm_getcap(struct tpm_chip *chip, __be32 subcap_id, cap_t *cap, > *cap = tpm_cmd.params.getcap_out.cap; > return rc; > } > +EXPORT_SYMBOL_GPL(tpm_getcap); > > #define TPM_ORD_STARTUP cpu_to_be32(153) > #define TPM_ST_CLEAR cpu_to_be16(1) > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > index e1db404..499f405 100644 > --- a/drivers/char/tpm/tpm2-cmd.c > +++ b/drivers/char/tpm/tpm2-cmd.c > @@ -707,6 +707,7 @@ ssize_t tpm2_get_tpm_pt(struct tpm_chip *chip, u32 property_id, u32 *value, > > return rc; > } > +EXPORT_SYMBOL_GPL(tpm2_get_tpm_pt); > > #define TPM2_STARTUP_IN_SIZE \ > (sizeof(struct tpm_input_header) + \ > -- > 2.7.4 >