From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbcHHUfG (ORCPT ); Mon, 8 Aug 2016 16:35:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:23731 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751582AbcHHUfE (ORCPT ); Mon, 8 Aug 2016 16:35:04 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Mon, 8 Aug 2016 13:35:03 -0700 From: "Paul E. McKenney" To: Richard Weinberger Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags' Reply-To: paulmck@linux.vnet.ibm.com References: <201606060200.kVmeQzvA%fengguang.wu@intel.com> <20160614225417.GR3923@linux.vnet.ibm.com> <5760FE41.9060603@nod.at> <20160615124532.GW3923@linux.vnet.ibm.com> <57A8E79B.7020009@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57A8E79B.7020009@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16080820-0044-0000-0000-000000DCE76B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005568; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000178; SDB=6.00741888; UDB=6.00349145; IPR=6.00514446; BA=6.00004651; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012252; XFM=3.00000011; UTC=2016-08-08 20:35:03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16080820-0045-0000-0000-000004F329FB Message-Id: <20160808203503.GM3482@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-08_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608080220 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 10:12:11PM +0200, Richard Weinberger wrote: > Paul, > > Am 15.06.2016 um 14:45 schrieb Paul E. McKenney: > > On Wed, Jun 15, 2016 at 09:05:37AM +0200, Richard Weinberger wrote: > >> Paul, > >> > >> Am 15.06.2016 um 00:54 schrieb Paul E. McKenney: > >>> On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote: > >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > >>>> head: 13ee0de9cd2444b57ce30c4f1607b49b90aa0c38 > >>>> commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled > >>>> config: um-allmodconfig (attached as .config) > >>>> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 > >>>> reproduce: > >>>> git checkout f251ac814fc5787765009e60d54a2bd4277350c8 > >>>> # save the attached .config to linux build tree > >>>> make ARCH=um > >>> > >>> My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on > >>> !UML or something similar. > >>> > >>> Another approach would be create a arch_irqs_disabled_flags() for UML. > >>> > >>> Any preferences? > >> > >> Patches for arch_irqs_disabled_flags() support are already on LKML: > >> https://lkml.org/lkml/2016/6/12/162 > >> > >> My plan was to merge them in the v4.8 merge window. > >> So having CONFIG_TASKS_RCU depend on !UML for now should be fine. > >> We can remove the dependency in v4.8 again. > > > > Sounds very good, thank you! > > The patch is now in Linus' tree. So, you can enable CONFIG_TASKS_RCU > for UML again. :-) Very good, thank you! I have a patch slated for the next merge window. If you need it sooner, please let me know. Thanx, Paul