From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbcHHWXZ (ORCPT ); Mon, 8 Aug 2016 18:23:25 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:34400 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbcHHWXX (ORCPT ); Mon, 8 Aug 2016 18:23:23 -0400 Date: Mon, 8 Aug 2016 15:23:19 -0700 From: Brian Norris To: Lars-Peter Clausen Cc: Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Brian Norris , Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH] iio: fix sched WARNING "do not call blocking ops when !TASK_RUNNING" Message-ID: <20160808222317.GA13805@localhost> References: <20160802011244.GA54171@google.com> <37ea974c-9ac6-5a40-0f0e-ee34ef605a08@metafoo.de> <20160802165732.GA3310@localhost> <9a6a7f54-0343-db74-57a2-9f747ae659cc@metafoo.de> <20160804082621.GA11331@localhost> <489632a0-9aaf-e63b-4b08-0fa724a06e28@metafoo.de> <20160804094113.GA25537@localhost> <8741ae27-2279-4615-7917-e3e3683e41fa@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8741ae27-2279-4615-7917-e3e3683e41fa@metafoo.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lars, On Thu, Aug 04, 2016 at 12:21:08PM +0200, Lars-Peter Clausen wrote: > And then also drop the if (!indio_dev->info) at the beginning of the function. I was poking through the usage of this ->info field, and it looks like it's supposed to be protected by the 'info_exist_lock' lock, but that's not being acquired here and in at least one other location. Is this another bug? Brian