From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbcHIG5W (ORCPT ); Tue, 9 Aug 2016 02:57:22 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33486 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbcHIG5T (ORCPT ); Tue, 9 Aug 2016 02:57:19 -0400 Date: Tue, 9 Aug 2016 08:56:00 +0200 From: Borislav Petkov To: york sun Cc: "linux-edac@vger.kernel.org" , "morbidrsa@gmail.com" , "oss@buserror.net" , Stuart Yoder , Doug Thompson , "mchehab@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 Message-ID: <20160809065600.GA3763@nazgul.tnic> References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-4-git-send-email-york.sun@nxp.com> <20160808071111.GB20800@nazgul.tnic> <20160809033204.GA11445@nazgul.tnic> <20160809050109.GA18922@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2016 at 05:06:39AM +0000, york sun wrote: > It is uncorrectable. DDR controller can only report the error. I don't > believe EDAC driver can do more. For the same reason I said we can leave > RXFE as is, even for e500v1 case (with RIO or PCI is enabled). Nothing > can be done with uncorrectable error. Of course it can: it can panic the machine so that it doesn't corrupt data on secondary storage. You might consider whether this is a better course of action instead of only reporting the error. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --