From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932829AbcHIOHv (ORCPT ); Tue, 9 Aug 2016 10:07:51 -0400 Received: from tex.lwn.net ([70.33.254.29]:47484 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbcHIOHu (ORCPT ); Tue, 9 Aug 2016 10:07:50 -0400 Date: Tue, 9 Aug 2016 08:07:48 -0600 From: Jonathan Corbet To: Daniel Vetter Cc: LKML , Jani Nikula , Markus Heiser , Daniel Vetter Subject: Re: [PATCH] Revert "Revert "doc/sphinx: Enable keep_warnings"" Message-ID: <20160809080748.18fef9d4@lwn.net> In-Reply-To: References: <1470673391-13635-1-git-send-email-daniel.vetter@ffwll.ch> <20160808153235.188f6d1d@lwn.net> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Aug 2016 15:56:15 +0200 Daniel Vetter wrote: > > So I honestly think we should just set the highlight language to "none" by > > default. The syntax highlighting in code samples adds some colorful sugar > > to the docs, but it's not really all that useful, IMO, and people who want > > it can override the language in the right places. > > > > Any strong opposition to this idea? > > Hm right, didn't realize that this is where it's coming from. No > strong opinion from my side on highlighting the C block quotes really. > Otoh that highlighting is rather pretty. Could we perhaps just shut > sphinx up about the "C" highlighting issues? We can look into that, but, in the end, we'll always have a lot of literal blocks that are not C code. Even if Sphinx doesn't warn about them, it tries to mark them up as C with occasionally strange results. I'm not really convinced it's a net win. jon