From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932355AbcHIMSB (ORCPT ); Tue, 9 Aug 2016 08:18:01 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47071 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752046AbcHIMR4 (ORCPT ); Tue, 9 Aug 2016 08:17:56 -0400 Date: Tue, 9 Aug 2016 14:17:53 +0200 From: Alexandre Belloni To: Julia Lawall Cc: Christophe JAILLET , a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test Message-ID: <20160809121753.GZ8132@piout.net> References: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote : > > > On Tue, 9 Aug 2016, Christophe JAILLET wrote: > > > It is likely that checking the result of 'pcf2123_write_reg' is expected > > here. > > Also fix a small style issue. The '{' at the beginning of the function > > is misplaced. > > They shouldn't be in the same patch. If you are wrong about the ret > issue, the { should still be moved. > That is true but as it is a really trivial patch, I didn't care that much. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com