From: Lee Jones <lee.jones@linaro.org>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: LINUXKERNEL <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] mfd: da9063: Update author information to remove incorrect e-mail addresses
Date: Tue, 9 Aug 2016 13:49:04 +0100 [thread overview]
Message-ID: <20160809124904.GD5243@dell> (raw)
In-Reply-To: <20160808132226.8EA233FB7C@swsrvapps-01.diasemi.com>
On Mon, 08 Aug 2016, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@diasemi.com>
>
> Remove incorrect e-mail addresses from the copyright header and
> MODULE_AUTHOR() macro. These e-mail addresses are no longer in use.
>
> The author names have not been changed, only the e-mail addresses have
> been deleted from the source files.
>
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
>
> ---
> Patch History
> -------------
> PATCH V2
> - Also include company name. Change now of the form: <NAME>, <COMPANY>
> e.g. Krystian Garbaciak, Dialog Semiconductor
> - I have *not* changed the MODULE_AUTHOR() information to include the
> company name, this still removes the old, invalid, e-mail address.
>
> Hi Lee,
>
> I have completed the changes to add the company name to the copyright
> headers, however, I have *not* changed any MODULE_AUTHOR() macros
> to include the company name.
>
> The alterations to the drivers/mfd/da9063-core.c file include the removal
> of the e-mail addresses only. This is because I have added the company name
> at the top of the file in the copyright header and because the
> recommendation from the include/linux/module.h file allows just the NAME
> to exist (without E-MAIL).
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h
>
> If that is still not acceptible, please let me know.
>
> Just to re-iterate our point of view. Our intention with this change is
> to encourage the group contact e-mail address for any support questions.
> Not to mess with copyright or author information.
>
> We have an e-mail address in the MAINTAINERS file covering all of the
> developers under a single contact group, support.opensource@diasemi.com,
> but that is not acceptable for individual submissions where a single person
> is responsible.
>
> drivers/mfd/da9063-core.c | 7 ++++---
> drivers/mfd/da9063-i2c.c | 2 +-
> drivers/mfd/da9063-irq.c | 2 +-
> include/linux/mfd/da9063/core.h | 4 ++--
> include/linux/mfd/da9063/pdata.h | 4 ++--
> include/linux/mfd/da9063/registers.h | 4 ++--
> 6 files changed, 12 insertions(+), 11 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> index af841c1..6c2870d 100644
> --- a/drivers/mfd/da9063-core.c
> +++ b/drivers/mfd/da9063-core.c
> @@ -4,8 +4,8 @@
> * Copyright 2012 Dialog Semiconductors Ltd.
> * Copyright 2013 Philipp Zabel, Pengutronix
> *
> - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>,
> - * Michal Hajduk <michal.hajduk@diasemi.com>
> + * Author: Krystian Garbaciak, Dialog Semiconductor
> + * Author: Michal Hajduk, Dialog Semiconductor
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> @@ -242,5 +242,6 @@ void da9063_device_exit(struct da9063 *da9063)
> }
>
> MODULE_DESCRIPTION("PMIC driver for Dialog DA9063");
> -MODULE_AUTHOR("Krystian Garbaciak <krystian.garbaciak@diasemi.com>, Michal Hajduk <michal.hajduk@diasemi.com>");
> +MODULE_AUTHOR("Krystian Garbaciak");
> +MODULE_AUTHOR("Michal Hajduk");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 7390108..981805a 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -3,7 +3,7 @@
> * Copyright 2012 Dialog Semiconductor Ltd.
> * Copyright 2013 Philipp Zabel, Pengutronix
> *
> - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Krystian Garbaciak, Dialog Semiconductor
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 7e903fc..207bbfe 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -3,7 +3,7 @@
> * Copyright 2012 Dialog Semiconductor Ltd.
> * Copyright 2013 Philipp Zabel, Pengutronix
> *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> + * Author: Michal Hajduk, Dialog Semiconductor
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> diff --git a/include/linux/mfd/da9063/core.h b/include/linux/mfd/da9063/core.h
> index 621af82..f3ae65d 100644
> --- a/include/linux/mfd/da9063/core.h
> +++ b/include/linux/mfd/da9063/core.h
> @@ -3,8 +3,8 @@
> *
> * Copyright 2012 Dialog Semiconductor Ltd.
> *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> - * Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Michal Hajduk, Dialog Semiconductor
> + * Author: Krystian Garbaciak, Dialog Semiconductor
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
> index 612383b..8a12570 100644
> --- a/include/linux/mfd/da9063/pdata.h
> +++ b/include/linux/mfd/da9063/pdata.h
> @@ -3,8 +3,8 @@
> *
> * Copyright 2012 Dialog Semiconductor Ltd.
> *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Michal Hajduk, Dialog Semiconductor
> + * Author: Krystian Garbaciak, Dialog Semiconductor
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> diff --git a/include/linux/mfd/da9063/registers.h b/include/linux/mfd/da9063/registers.h
> index 2e0ba6d..5d42859 100644
> --- a/include/linux/mfd/da9063/registers.h
> +++ b/include/linux/mfd/da9063/registers.h
> @@ -3,8 +3,8 @@
> *
> * Copyright 2012 Dialog Semiconductor Ltd.
> *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> - * Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Michal Hajduk, Dialog Semiconductor
> + * Author: Krystian Garbaciak, Dialog Semiconductor
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-08-09 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 13:16 [PATCH V2] mfd: da9063: Update author information to remove incorrect e-mail addresses Steve Twiss
2016-08-09 12:49 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809124904.GD5243@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox