From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932421AbcHIM42 (ORCPT ); Tue, 9 Aug 2016 08:56:28 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36336 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240AbcHIM40 (ORCPT ); Tue, 9 Aug 2016 08:56:26 -0400 Date: Tue, 9 Aug 2016 13:57:53 +0100 From: Lee Jones To: Andrey Smirnov Cc: linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] mfd: syscon: Make use of of_iomap Message-ID: <20160809125753.GH5243@dell> References: <1470589699-7079-1-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1470589699-7079-1-git-send-email-andrew.smirnov@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 07 Aug 2016, Andrey Smirnov wrote: > Use of_iomap instead of explicitly calling of_address_to_resource() and > ioremap(). > > Signed-off-by: Andrey Smirnov > --- > drivers/mfd/syscon.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > index 2f2225e..55b883d 100644 > --- a/drivers/mfd/syscon.c > +++ b/drivers/mfd/syscon.c > @@ -59,12 +59,7 @@ static struct syscon *of_syscon_register(struct device_node *np) > if (!syscon) > return ERR_PTR(-ENOMEM); > > - if (of_address_to_resource(np, 0, &res)) { > - ret = -ENOMEM; > - goto err_map; > - } > - > - base = ioremap(res.start, resource_size(&res)); > + base = of_iomap(np, 0); > if (!base) { > ret = -ENOMEM; > goto err_map; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog