From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932666AbcHINAD (ORCPT ); Tue, 9 Aug 2016 09:00:03 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32829 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932309AbcHINAC (ORCPT ); Tue, 9 Aug 2016 09:00:02 -0400 Date: Tue, 9 Aug 2016 13:59:52 +0100 From: Salah Triki To: Luis de Bethencourt Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] fs: befs: check flags field to validate the superblock state Message-ID: <20160809125952.GA17353@pc> References: <9f647c2c2067379143fe85dfcb94842dbed0a97e.1470745951.git.salah.triki@gmail.com> <03eea80e0188d9cab423cf517659280afd04d7b2.1470745951.git.salah.triki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2016 at 01:40:25PM +0100, Luis de Bethencourt wrote: > On 09/08/16 13:32, Salah Triki wrote: > > flags field records the superblock state, so check if it is equal to > > BEFS_DIRTY. > > > > Signed-off-by: Salah Triki > > --- > > fs/befs/super.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/befs/super.c b/fs/befs/super.c > > index 5ab75e8..79be409 100644 > > --- a/fs/befs/super.c > > +++ b/fs/befs/super.c > > @@ -103,7 +103,7 @@ befs_check_sb(struct super_block *sb) > > return BEFS_ERR; > > } > > > > - if (befs_sb->log_start != befs_sb->log_end) { > > + if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) { > > befs_error(sb, "Filesystem not clean! There are blocks in the " > > "journal. You must boot into BeOS and mount this volume " > > "to make it clean."); > > > > Hi Salah, > > Looks like a good idea. Any reason why commit 1/2, where you add the flag, and commit > 2/2, where you read it, are split and not in the same commit? Curious. > > Will test it soon. > > Thanks :) > Luis Hi Luis, I split the two commits for sake of clarity. But now I realize that it is not usefull at all. Will send a corrected patch soon. Thanx Salah