From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932688AbcHINCF (ORCPT ); Tue, 9 Aug 2016 09:02:05 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37811 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932539AbcHINCB (ORCPT ); Tue, 9 Aug 2016 09:02:01 -0400 Date: Tue, 9 Aug 2016 14:03:27 +0100 From: Lee Jones To: Axel Lin Cc: Thor Thayer , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const Message-ID: <20160809130326.GI5243@dell> References: <1470379231-3248-1-git-send-email-axel.lin@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1470379231-3248-1-git-send-email-axel.lin@ingics.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Aug 2016, Axel Lin wrote: > It's only used in this driver and never get modified, make it static const. > > Signed-off-by: Axel Lin > --- > drivers/mfd/altera-a10sr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c > index c05aa4f..40ed65e 100644 > --- a/drivers/mfd/altera-a10sr.c > +++ b/drivers/mfd/altera-a10sr.c > @@ -94,7 +94,7 @@ static bool altr_a10sr_reg_volatile(struct device *dev, unsigned int reg) > } > } > > -const struct regmap_config altr_a10sr_regmap_config = { > +static const struct regmap_config altr_a10sr_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog