From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932795AbcHINk7 (ORCPT ); Tue, 9 Aug 2016 09:40:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59814 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932507AbcHINk6 (ORCPT ); Tue, 9 Aug 2016 09:40:58 -0400 Date: Tue, 9 Aug 2016 15:41:10 +0200 From: Greg Kroah-Hartman To: Bhaktipriya Shridhar Cc: Julia Lawall , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: Re: [RFC] whci: Remove deprecated create_singlethread_workqueue Message-ID: <20160809134110.GA28161@kroah.com> References: <20160727090915.GA24974@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160727090915.GA24974@Karyakshetra> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 02:39:16PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > The workqueue "workqueue" has multiple workitems which may require > ordering. Hence, a dedicated ordered workqueue has been used. > Since the workqueue is not being used on a memory reclaim path, > WQ_MEM_RECLAIM has not been set. > > Can the workitems run concurrently? Is the ordering among work items necessary? I don't know, sorry. Almost no one has this hardware, so just fix it the best you can and let's see what happens :) thanks, greg k-h