From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"open list:USB OHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: ohci-platform: use helper variables in probe function
Date: Tue, 9 Aug 2016 15:59:11 +0200 [thread overview]
Message-ID: <20160809135911.GA3021@kroah.com> (raw)
In-Reply-To: <1468559930-28432-1-git-send-email-zajec5@gmail.com>
On Fri, Jul 15, 2016 at 07:18:50AM +0200, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> drivers/usb/host/ohci-platform.c | 66 +++++++++++++++++++---------------------
> 1 file changed, 32 insertions(+), 34 deletions(-)
While "nice" this really isn't needed, unless you are going to do
something after this patch is applied. And if so, please submit it as a
patch series. As it is, it just looks like unneeded churn, sorry, so
I'm not going to take it.
thanks,
greg k-h
prev parent reply other threads:[~2016-08-09 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 5:18 [PATCH] usb: ohci-platform: use helper variables in probe function Rafał Miłecki
2016-07-15 19:52 ` Alan Stern
2016-08-09 13:59 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809135911.GA3021@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox