From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932910AbcHIN7B (ORCPT ); Tue, 9 Aug 2016 09:59:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60087 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932558AbcHIN67 (ORCPT ); Tue, 9 Aug 2016 09:58:59 -0400 Date: Tue, 9 Aug 2016 15:59:11 +0200 From: Greg Kroah-Hartman To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Alan Stern , "open list:USB OHCI DRIVER" , open list Subject: Re: [PATCH] usb: ohci-platform: use helper variables in probe function Message-ID: <20160809135911.GA3021@kroah.com> References: <1468559930-28432-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468559930-28432-1-git-send-email-zajec5@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 07:18:50AM +0200, Rafał Miłecki wrote: > Probing function was using &dev->dev and dev->dev.of_node over 20 times > so I believe it made sense to use helper variables for both of them. > To avoid some uncommon variable name for struct device I first replaced > existing dev variable with pdev. > > Signed-off-by: Rafał Miłecki > Acked-by: Alan Stern > --- > drivers/usb/host/ohci-platform.c | 66 +++++++++++++++++++--------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) While "nice" this really isn't needed, unless you are going to do something after this patch is applied. And if so, please submit it as a patch series. As it is, it just looks like unneeded churn, sorry, so I'm not going to take it. thanks, greg k-h