public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Binderman <linuxdev.baldrick@gmail.com>
Cc: valentina.manea.m@gmail.com, shuahkh@osg.samsung.com,
	linux-usb@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dcb314@hotmail.com
Subject: Re: drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?
Date: Tue, 9 Aug 2016 16:09:40 +0200	[thread overview]
Message-ID: <20160809140940.GA14884@kroah.com> (raw)
In-Reply-To: <CAMzoamaxBaezxvEw3x6rgPLmYZ6xEhZjbxg=_3-LzEKDdBJ5xw@mail.gmail.com>

On Mon, Jul 18, 2016 at 01:29:05PM +0100, David Binderman wrote:
> Hello there,
> 
> drivers/usb/usbip/vudc_rx.c:145:27: warning: result of ‘11 << 30’
> requires 35 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
> 
> Source code is
> 
>     urb_p->urb->pipe &= ~(11 << 30);
> 
> Maybe better code
> 
>     urb_p->urb->pipe &= ~(11UL << 30);

Perhaps, care to send a patch?

thanks,

greg k-h

      reply	other threads:[~2016-08-09 14:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 12:29 drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ? David Binderman
2016-08-09 14:09 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160809140940.GA14884@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dcb314@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxdev.baldrick@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox