From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932872AbcHIOJa (ORCPT ); Tue, 9 Aug 2016 10:09:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60196 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbcHIOJ1 (ORCPT ); Tue, 9 Aug 2016 10:09:27 -0400 Date: Tue, 9 Aug 2016 16:09:40 +0200 From: Greg KH To: David Binderman Cc: valentina.manea.m@gmail.com, shuahkh@osg.samsung.com, linux-usb@vger.kernel.org, Linux Kernel Mailing List , dcb314@hotmail.com Subject: Re: drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ? Message-ID: <20160809140940.GA14884@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 01:29:05PM +0100, David Binderman wrote: > Hello there, > > drivers/usb/usbip/vudc_rx.c:145:27: warning: result of β€˜11 << 30’ > requires 35 bits to represent, but β€˜int’ only has 32 bits > [-Wshift-overflow=] > > Source code is > > urb_p->urb->pipe &= ~(11 << 30); > > Maybe better code > > urb_p->urb->pipe &= ~(11UL << 30); Perhaps, care to send a patch? thanks, greg k-h