From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932697AbcHIOyc (ORCPT ); Tue, 9 Aug 2016 10:54:32 -0400 Received: from 8bytes.org ([81.169.241.247]:42297 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbcHIOya (ORCPT ); Tue, 9 Aug 2016 10:54:30 -0400 Date: Tue, 9 Aug 2016 16:54:26 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: rkrcmar@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sherry.hurwitz@amd.com Subject: Re: [PART2 PATCH v5 09/12] iommu/amd: Enable vAPIC interrupt remapping mode by default Message-ID: <20160809145426.GD1437@8bytes.org> References: <1469439131-11308-1-git-send-email-suravee.suthikulpanit@amd.com> <1469439131-11308-10-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469439131-11308-10-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 04:32:08AM -0500, Suthikulpanit, Suravee wrote: > From: Suravee Suthikulpanit > > Introduce struct iommu_dev_data.use_vapic flag, which IOMMU driver > uses to determine if it should enable vAPIC support, by setting > the ga_mode bit in the device's interrupt remapping table entry. > > Currently, it is enabled for all pass-through device if vAPIC mode > is enabled. > > Signed-off-by: Suravee Suthikulpanit > --- > drivers/iommu/amd_iommu.c | 44 +++++++++++++++++++++++++++++++++-------- > drivers/iommu/amd_iommu_init.c | 12 ++++++++++- > drivers/iommu/amd_iommu_types.h | 2 +- > 3 files changed, 48 insertions(+), 10 deletions(-) > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > index a044ce4..155b4a6 100644 > --- a/drivers/iommu/amd_iommu.c > +++ b/drivers/iommu/amd_iommu.c > @@ -105,6 +105,7 @@ struct iommu_dev_data { > bool pri_tlp; /* PASID TLB required for > PPR completions */ > u32 errata; /* Bitmap for errata to apply */ > + u32 use_vapic; /* Enable device to use vapic mode */ bool is a better choice here.