From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbcHIP44 (ORCPT ); Tue, 9 Aug 2016 11:56:56 -0400 Received: from mga04.intel.com ([192.55.52.120]:22384 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbcHIP4z (ORCPT ); Tue, 9 Aug 2016 11:56:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,494,1464678000"; d="scan'208";a="1032510093" Date: Tue, 9 Aug 2016 18:56:49 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Arnd Bergmann Cc: Geert Uytterhoeven , Alexandre Belloni , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Alessandro Zummo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: rtc regression [463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h")] Message-ID: <20160809155649.GX4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, commit 463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h") broke rtc for me. Neither hwclock or rtcwake work anymore. This is just a very standard x86-64 IVB box, and it was reported that machines in our i915 test farm are having rtc related problems as well. The first time I run hwclock after rebooting I get this: open("/dev/rtc", O_RDONLY) = 3 ioctl(3, PHN_SET_REGS or RTC_UIE_ON, 0) = 0 select(4, [3], NULL, NULL, {10, 0}) = 0 (Timeout) ioctl(3, PHN_NOT_OH or RTC_UIE_OFF, 0) = 0 close(3) = 0 On all subsequent runs I get this: open("/dev/rtc", O_RDONLY) = 3 ioctl(3, PHN_SET_REGS or RTC_UIE_ON, 0) = -1 EINVAL (Invalid argument) ioctl(3, RTC_RD_TIME, 0x7ffd76b3ae70) = -1 EINVAL (Invalid argument) close(3) = 0 463a86304cae^ gets me back to working condition: open("/dev/rtc", O_RDONLY) = 3 ioctl(3, PHN_SET_REGS or RTC_UIE_ON, 0) = 0 select(4, [3], NULL, NULL, {10, 0}) = 1 (in [3], left {9, 530998}) ioctl(3, PHN_NOT_OH or RTC_UIE_OFF, 0) = 0 ioctl(3, RTC_RD_TIME, {tm_sec=20, tm_min=17, tm_hour=15, tm_mday=9, tm_mon=7, tm_year=116, ...}) = 0 close(3) = 0 -- Ville Syrjälä Intel OTC