From: Mark Brown <broonie@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kbuild-all@01.org
Subject: Re: drivers/spi/spi.c:1160:3-9: preceding lock on line 1153
Date: Tue, 9 Aug 2016 17:43:48 +0100 [thread overview]
Message-ID: <20160809164348.GD9347@sirena.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.10.1608091832280.2911@hadrien>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Tue, Aug 09, 2016 at 06:35:06PM +0200, Julia Lawall wrote:
> On Tue, 9 Aug 2016, Mark Brown wrote:
> > On Tue, Aug 09, 2016 at 06:19:13PM +0200, Julia Lawall wrote:
> > > Looks worth checking.
> > I don't really have any idea what this is trying to tell me, sorry.
> The important lines are the ones with the @. Line 1153 takes a lock and
> in line 1160 there is a return in error handling code with the lock still
> held. The semantic patch that reported this should also only give a
> report if there is some patch out of the function that releases the lock.
> Overall, it seems unusual to keep the lock in an error case.
I'm not sure how I'm supposed to identify that from the message to be
honest - I'd expect something that more directly referenced both lines
and ideally said something like "lock held when returning". But yes, it
does look like an issue thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-08-09 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 16:19 drivers/spi/spi.c:1160:3-9: preceding lock on line 1153 Julia Lawall
2016-08-09 16:31 ` Mark Brown
2016-08-09 16:35 ` Julia Lawall
2016-08-09 16:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809164348.GD9347@sirena.org.uk \
--to=broonie@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox