From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932645AbcHIQ65 (ORCPT ); Tue, 9 Aug 2016 12:58:57 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46774 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932245AbcHIQ6x (ORCPT ); Tue, 9 Aug 2016 12:58:53 -0400 Date: Tue, 9 Aug 2016 18:58:30 +0200 From: Borislav Petkov To: york sun Cc: "linux-edac@vger.kernel.org" , "morbidrsa@gmail.com" , "oss@buserror.net" , Stuart Yoder , Doug Thompson , "mchehab@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 Message-ID: <20160809165830.GA19353@nazgul.tnic> References: <1470351518-22404-4-git-send-email-york.sun@nxp.com> <20160808071111.GB20800@nazgul.tnic> <20160809033204.GA11445@nazgul.tnic> <20160809050109.GA18922@nazgul.tnic> <20160809065600.GA3763@nazgul.tnic> <275db5cd-09cd-d971-0e43-3b4af060f0e8@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2016 at 04:40:44PM +0000, york sun wrote: > I want to add this, normally uncorrectable errors don't trigger machine > check on e500v1. RXFE controls different interrupt on e500v2. e500mc > doesn't support RXFE. Together with the reason I explained, I believe > EDAC driver shouldn't change RXFE. > > I hope I made it clear. Yes, you did, thanks. I reread Scott's previous mail too and yes, it doesn't make a whole lotta sense to touch the RXFE bit in EDAC. I'm assuming firmware leaves it cleared coming out of reset so we're all good. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --