From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932602AbcHIQ6u (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Aug 2016 12:58:50 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:35482 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932245AbcHIQ6q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Aug 2016 12:58:46 -0400
Date: Tue, 9 Aug 2016 19:58:40 +0300
From: Alexey Dobriyan <adobriyan@gmail.com>
To: robert.foss@collabora.com
Cc: akpm@linux-foundation.org, keescook@chromium.org, viro@zeniv.linux.org.uk,
        gorcunov@openvz.org, john.stultz@linaro.org,
        plaguedbypenguins@gmail.com, sonnyrao@chromium.org, mguzik@redhat.com,
        jdanis@google.com, calvinowens@fb.com, jann@thejh.net, mhocko@suse.com,
        koct9i@gmail.com, vbabka@suse.cz, n-horiguchi@ah.jp.nec.com,
        kirill.shutemov@linux.intel.com, ldufour@linux.vnet.ibm.com,
        hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
        Ben Zhang <benzh@chromium.org>, Bryan Freed <bfreed@chromium.org>,
        Filipe Brandenburger <filbranden@chromium.org>
Subject: Re: [PACTH v1] mm, proc: Implement /proc/<pid>/totmaps
Message-ID: <20160809165840.GA18881@p183.telecom.by>
References: <1470758743-17685-1-git-send-email-robert.foss@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470758743-17685-1-git-send-email-robert.foss@collabora.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.foss@collabora.com wrote:
> From: Sonny Rao <sonnyrao@chromium.org>
> 
> This is based on earlier work by Thiago Goncales. It implements a new
> per process proc file which summarizes the contents of the smaps file
> but doesn't display any addresses.  It gives more detailed information
> than statm like the PSS (proprotional set size).  It differs from the
> original implementation in that it doesn't use the full blown set of
> seq operations, uses a different termination condition, and doesn't
> displayed "Locked" as that was broken on the original implemenation.
> 
> This new proc file provides information faster than parsing the potentially
> huge smaps file.

You can "parse" /proc/*/pagemap . RSS, swap are there.
So which ones do you really need?
Why the separate anon hugepages and anon regular pages?

> +	seq_printf(m,
> +		   "Rss:            %8lu kB\n"
> +		   "Pss:            %8lu kB\n"
> +		   "Shared_Clean:   %8lu kB\n"
> +		   "Shared_Dirty:   %8lu kB\n"
> +		   "Private_Clean:  %8lu kB\n"
> +		   "Private_Dirty:  %8lu kB\n"
> +		   "Referenced:     %8lu kB\n"
> +		   "Anonymous:      %8lu kB\n"
> +		   "AnonHugePages:  %8lu kB\n"
> +		   "Swap:           %8lu kB\n",
> +		   mss_sum->resident >> 10,
> +		   (unsigned long)(mss_sum->pss >> (10 + PSS_SHIFT)),
> +		   mss_sum->shared_clean  >> 10,
> +		   mss_sum->shared_dirty  >> 10,
> +		   mss_sum->private_clean >> 10,
> +		   mss_sum->private_dirty >> 10,
> +		   mss_sum->referenced >> 10,
> +		   mss_sum->anonymous >> 10,
> +		   mss_sum->anonymous_thp >> 10,
> +		   mss_sum->swap >> 10);