From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932343AbcHIRhM (ORCPT ); Tue, 9 Aug 2016 13:37:12 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34794 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbcHIRhJ (ORCPT ); Tue, 9 Aug 2016 13:37:09 -0400 Date: Tue, 9 Aug 2016 10:36:53 -0700 From: Bjorn Andersson To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, patrice.chotard@st.com, ohad@wizery.com, linux-remoteproc@vger.kernel.org, loic.pallardy@st.com Subject: Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Message-ID: <20160809173653.GD26240@tuxbot> References: <20160804092153.23032-1-lee.jones@linaro.org> <20160804092153.23032-4-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160804092153.23032-4-lee.jones@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > These types of error prints are superfluous. The system will > pick up on OOM issues and let the user know. > > Signed-off-by: Lee Jones Acked-by: Bjorn Andersson Although, I think we should drop the "mapping" object. We have all the information in the carveout object to reverse the mapping at cleanup. Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 5654a81..4914482 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -619,7 +619,6 @@ static int rproc_handle_carveout(struct rproc *rproc, > if (rproc->domain) { > mapping = kzalloc(sizeof(*mapping), GFP_KERNEL); > if (!mapping) { > - dev_err(dev, "kzalloc mapping failed\n"); > ret = -ENOMEM; > goto dma_free; > } > -- > 2.9.0 >