From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932324AbcHISJm (ORCPT ); Tue, 9 Aug 2016 14:09:42 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35211 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbcHISJf (ORCPT ); Tue, 9 Aug 2016 14:09:35 -0400 Date: Tue, 9 Aug 2016 19:10:56 +0100 From: Lee Jones To: Bjorn Andersson Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, patrice.chotard@st.com, ohad@wizery.com, linux-remoteproc@vger.kernel.org, loic.pallardy@st.com Subject: Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Message-ID: <20160809181056.GA1581@dell> References: <20160804092153.23032-1-lee.jones@linaro.org> <20160804092153.23032-4-lee.jones@linaro.org> <20160809173653.GD26240@tuxbot> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160809173653.GD26240@tuxbot> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Aug 2016, Bjorn Andersson wrote: > On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > > > These types of error prints are superfluous. The system will > > pick up on OOM issues and let the user know. > > > > Signed-off-by: Lee Jones > > Acked-by: Bjorn Andersson This doesn't rely on anything else, so you can just take it. > Although, I think we should drop the "mapping" object. We have all the > information in the carveout object to reverse the mapping at cleanup. Let's fix it for now, then work on 'nice to have's in a subsequent set. > > --- > > drivers/remoteproc/remoteproc_core.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > > index 5654a81..4914482 100644 > > --- a/drivers/remoteproc/remoteproc_core.c > > +++ b/drivers/remoteproc/remoteproc_core.c > > @@ -619,7 +619,6 @@ static int rproc_handle_carveout(struct rproc *rproc, > > if (rproc->domain) { > > mapping = kzalloc(sizeof(*mapping), GFP_KERNEL); > > if (!mapping) { > > - dev_err(dev, "kzalloc mapping failed\n"); > > ret = -ENOMEM; > > goto dma_free; > > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog