From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbcHIUtG (ORCPT ); Tue, 9 Aug 2016 16:49:06 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38812 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbcHIUtF (ORCPT ); Tue, 9 Aug 2016 16:49:05 -0400 Date: Tue, 9 Aug 2016 21:50:31 +0100 From: Lee Jones To: Sylwester Nawrocki Cc: broonie@kernel.org, robh@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, ideal.song@samsung.com, inki.dae@samsung.com, b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Beomho Seo Subject: Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver Message-ID: <20160809205031.GD1581@dell> References: <1467738804-31460-1-git-send-email-s.nawrocki@samsung.com> <20160809150502.GQ5243@dell> <61d700f7-ef66-8278-54ea-8e6e2f1a029e@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <61d700f7-ef66-8278-54ea-8e6e2f1a029e@samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Aug 2016, Sylwester Nawrocki wrote: > On 08/09/2016 05:05 PM, Lee Jones wrote: > >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, > >> > + exynos_lpass_resume); > > Put this up by the PM functions. > > Sorry, I don't understand this comment, which PM functions do you > mean exactly? *_suspend and *_resume. PM == Power Management. You also need to place the functions in side some CONFIG_PM_SLEEP guards. Grep around, you'll see what I mean. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog