From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbcHJSJk (ORCPT ); Wed, 10 Aug 2016 14:09:40 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36064 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932761AbcHJSJh (ORCPT ); Wed, 10 Aug 2016 14:09:37 -0400 Date: Wed, 10 Aug 2016 07:00:20 +0000 From: Karl Beldan To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , Santosh Shilimkar , Sekhar Nori , Kevin Hilman , Karl Beldan Subject: Re: [PATCH 1/4] memory: ti-aemif: Get a named clock rather than an unnamed one Message-ID: <20160810070019.GA14114@gobelin> References: <20160809171518.22690-1-kbeldan@baylibre.com> <20160809171518.22690-2-kbeldan@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160809171518.22690-2-kbeldan@baylibre.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2016 at 05:15:15PM +0000, Karl Beldan wrote: > Many davinci boards (da830 and da850 families) don't have their clocks > in DT yet and won't be successful in getting an unnamed aemif clock. > Also the sole current users of ti-aemif (keystone boards) use 'aemif' as > their aemif device clock clock-name and should remain unaffected. > > Signed-off-by: Karl Beldan > --- > drivers/memory/ti-aemif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c > index a579a0f..c251fc8 100644 > --- a/drivers/memory/ti-aemif.c > +++ b/drivers/memory/ti-aemif.c > @@ -345,7 +345,7 @@ static int aemif_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, aemif); > > - aemif->clk = devm_clk_get(dev, NULL); > + aemif->clk = devm_clk_get(dev, "aemif"); Looking further it seems to me that the struct clk_lookup da850_clks registered by davinci_clk_init() should be enough to clk_get() unnamed clocks using only the dev name. I look into what's going on but it would make this patch unnecessary. Karl