From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933896AbcHJSWb (ORCPT ); Wed, 10 Aug 2016 14:22:31 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:46538 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932480AbcHJSW1 (ORCPT ); Wed, 10 Aug 2016 14:22:27 -0400 Date: Wed, 10 Aug 2016 10:43:39 +0100 From: Russell King - ARM Linux To: Kees Cook Cc: kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, Ard Biesheuvel , x86@kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Mathias Krause , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] arm: apply more __ro_after_init Message-ID: <20160810094339.GK1041@n2100.armlinux.org.uk> References: <1464979224-2085-1-git-send-email-keescook@chromium.org> <1464979224-2085-3-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464979224-2085-3-git-send-email-keescook@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2016 at 11:40:24AM -0700, Kees Cook wrote: > @@ -1309,16 +1309,11 @@ void __init arm_mm_memblock_reserve(void) > * Any other function or debugging method which may touch any device _will_ > * crash the kernel. > */ > +static char vectors[PAGE_SIZE * 2] __ro_after_init __aligned(PAGE_SIZE); > static void __init devicemaps_init(const struct machine_desc *mdesc) > { > struct map_desc map; > unsigned long addr; > - void *vectors; > - > - /* > - * Allocate the vector page early. > - */ > - vectors = early_alloc(PAGE_SIZE * 2); This one is not appropriate. We _do_ write to these pages after init for FIQ handler updates. See set_fiq_handler(). -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.