From: Ingo Molnar <mingo@kernel.org>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/efi-bgrt: remove the check of the version field
Date: Wed, 10 Aug 2016 14:52:01 +0200 [thread overview]
Message-ID: <20160810125201.GA9028@gmail.com> (raw)
In-Reply-To: <20160809052546.31462-1-icenowy@aosc.xyz>
* Icenowy Zheng <icenowy@aosc.xyz> wrote:
> Some broken firmwares have a wrongly filled version field in BGRT table.
> (See http://wiki.osdev.org/Broken_UEFI_implementations )
>
> As we know, these firmwares can also provide correct BGRT image, although
> the table is wrong.
>
> After removing the check of the version field, the kernel can now extract
> the image correctly, and the information is also correct.
>
> Tested on a Thinkpad E531 (68854UC).
What's the practical effects of the bug - what problems does a missing
/sys/firmware/acpi/bgrt/ cause?
I.e. how does the user notice?
Thanks,
Ingo
next parent reply other threads:[~2016-08-10 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160809052546.31462-1-icenowy@aosc.xyz>
2016-08-10 12:52 ` Ingo Molnar [this message]
[not found] ` <120791470839405@web16h.yandex.ru>
2016-08-11 8:48 ` [PATCH] x86/efi-bgrt: remove the check of the version field Ingo Molnar
2016-08-15 12:56 ` Matt Fleming
2016-08-15 16:09 ` Josh Triplett
2016-08-17 5:44 ` Dave Young
2016-08-18 20:41 ` Matt Fleming
2016-08-22 7:28 ` Dave Young
[not found] ` <388401471855799@web30j.yandex.ru>
2016-08-24 7:30 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810125201.GA9028@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=icenowy@aosc.xyz \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).