From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941079AbcHJTBR (ORCPT ); Wed, 10 Aug 2016 15:01:17 -0400 Received: from mail.kernel.org ([198.145.29.136]:38416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938927AbcHJTBL (ORCPT ); Wed, 10 Aug 2016 15:01:11 -0400 Date: Wed, 10 Aug 2016 10:05:15 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf intel-pt: Fix ip compression Message-ID: <20160810130515.GE4249@kernel.org> References: <1469005206-3049-1-git-send-email-adrian.hunter@intel.com> <4cc98408-bf55-439a-e88b-15f1ca57b0ff@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cc98408-bf55-439a-e88b-15f1ca57b0ff@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Aug 10, 2016 at 11:32:21AM +0300, Adrian Hunter escreveu: > On 20/07/16 12:00, Adrian Hunter wrote: > > June 2015 Intel SDM introduced IP Compression types 4 and 6. Refer section > > 36.4.2.2 Target IP (TIP) Packet - IP Compression. > > Existing Intel PT packet decoder did not support type 4, and got type 6 > > wrong. Because type 3 and type 4 have the same number of bytes, the packet > > 'count' has been changed from being the number of ip bytes to being the > > type code. That allows the Intel PT decoder to correctly decide whether to > > sign-extend or use the last ip. However that also meant the code had to be > > adjusted in a number of places. > > > > Currently hardware is not using the new compression types, so this fix has > > no effect on existing hardware. > > > > Signed-off-by: Adrian Hunter > > --- > > .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 44 +++++++++++----------- > > .../util/intel-pt-decoder/intel-pt-pkt-decoder.c | 24 ++++++++---- > > 2 files changed, 40 insertions(+), 28 deletions(-) > Hi > This is outstanding but still applies. Oops, will get that merged, sorry for the delay. - Arnaldo