From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933558AbcHJVQr (ORCPT ); Wed, 10 Aug 2016 17:16:47 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60425 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932564AbcHJVQn (ORCPT ); Wed, 10 Aug 2016 17:16:43 -0400 Date: Wed, 10 Aug 2016 14:16:21 -0700 From: Guenter Roeck To: Brian Norris Cc: Dmitry Torokhov , Wolfram Sang , Lee Jones , Thierry Reding , Olof Johansson , Brian Norris , Javier Martinez Canillas , Enric Balletbo , Shawn Nematbakhsh , Gwendal Grignou , Tomeu Vizoso , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, "# 9798ac6d32c1 mfd : cros_ec : Add cros_ec_cmd_xfer_status helper" Subject: Re: [RESEND PATCH 2/2] Input: cros_ec_keyb - Fix usage of cros_ec_cmd_xfer() Message-ID: <20160810211621.GB21385@roeck-us.net> References: <1470861439-129201-1-git-send-email-briannorris@chromium.org> <1470861439-129201-3-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470861439-129201-3-git-send-email-briannorris@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2016 at 01:37:19PM -0700, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors and operating on uninitialized data. > > We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these > problems. Let's use it. > > [Regarding the 'Fixes' tag; there is significant refactoring since the driver's > introduction, but the underlying logical error exists throughout I believe] > > Fixes: 6af6dc2d2aa6 ("input: Add ChromeOS EC keyboard driver") > Cc: # 9798ac6d32c1 mfd: cros_ec: Add cros_ec_cmd_xfer_status() helper > Signed-off-by: Brian Norris > Reviewed-by: Javier Martinez Canillas > Acked-by: Dmitry Torokhov Reviewed-by: Guenter Roeck > --- > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > index b01966dc7eb3..6e48616a3a88 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -160,7 +160,7 @@ static int cros_ec_keyb_get_state(struct cros_ec_keyb *ckdev, uint8_t *kb_state) > msg->insize = ckdev->cols; > msg->outsize = 0; > > - ret = cros_ec_cmd_xfer(ckdev->ec, msg); > + ret = cros_ec_cmd_xfer_status(ckdev->ec, msg); > if (ret < 0) { > dev_err(ckdev->dev, "Error transferring EC message %d\n", ret); > goto exit; > -- > 2.8.0.rc3.226.g39d4020 >