From: Salah Triki <salah.triki@gmail.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
viro@zeniv.linux.org.uk, salah.triki@acm.org
Subject: Re: [PATCH 3/4] befs: fix comment style
Date: Wed, 10 Aug 2016 22:42:36 +0100 [thread overview]
Message-ID: <20160810214236.GB4372@pc> (raw)
In-Reply-To: <1470780086-11594-3-git-send-email-luisbg@osg.samsung.com>
On Tue, Aug 09, 2016 at 11:01:25PM +0100, Luis de Bethencourt wrote:
> The description of befs_load_sb was confusing the kernel-doc system since,
> because it starts with /**, it thinks it will document the function with
> kernel-doc formatting. Which it isn't.
>
> Fix other comment style issues in the file while we are at it.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> fs/befs/super.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index c36745d..80b93c0 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -13,13 +13,9 @@
> #include "befs.h"
> #include "super.h"
>
> -/**
> +/*
> * befs_load_sb -- Read from disk and properly byteswap all the fields
> * of the befs superblock
> - *
> - *
> - *
> - *
> */
> int
> befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)
> @@ -93,8 +89,8 @@ befs_check_sb(struct super_block *sb)
> }
>
> /*
> - * block_shift and block_size encode the same information
> - * in different ways as a consistency check.
> + * block_shift and block_size encode the same information
> + * in different ways as a consistency check.
> */
>
> if ((1 << befs_sb->block_shift) != befs_sb->block_size) {
> --
> 2.5.1
>
Signed-off-by: Salah Triki <salah.triki@gmail.com>
Thanx
Salah
next prev parent reply other threads:[~2016-08-10 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 22:01 [PATCH 1/4] befs: dump inode_size superblock information Luis de Bethencourt
2016-08-09 22:01 ` [PATCH 2/4] befs: add check for ag_shift in superblock Luis de Bethencourt
2016-08-11 14:58 ` Salah Triki
2016-08-09 22:01 ` [PATCH 3/4] befs: fix comment style Luis de Bethencourt
2016-08-10 21:42 ` Salah Triki [this message]
2016-08-09 22:01 ` [PATCH 4/4] befs: fix style issues in super.c Luis de Bethencourt
2016-08-10 21:44 ` Salah Triki
2016-08-10 21:41 ` [PATCH 1/4] befs: dump inode_size superblock information Salah Triki
2016-08-11 10:03 ` Luis de Bethencourt
2016-08-11 14:09 ` Salah Triki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810214236.GB4372@pc \
--to=salah.triki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=salah.triki@acm.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox