From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbcHJVpA (ORCPT ); Wed, 10 Aug 2016 17:45:00 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32803 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbcHJVo6 (ORCPT ); Wed, 10 Aug 2016 17:44:58 -0400 Date: Wed, 10 Aug 2016 22:44:48 +0100 From: Salah Triki To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, salah.triki@acm.org Subject: Re: [PATCH 4/4] befs: fix style issues in super.c Message-ID: <20160810214448.GC4372@pc> References: <1470780086-11594-1-git-send-email-luisbg@osg.samsung.com> <1470780086-11594-4-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470780086-11594-4-git-send-email-luisbg@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2016 at 11:01:26PM +0100, Luis de Bethencourt wrote: > Fixing the following checkpatch.pl error: > > ERROR: "foo * bar" should be "foo *bar" > +befs_load_sb(struct super_block *sb, befs_super_block * disk_sb) > > And the following warnings: > > WARNING: suspect code indent for conditional statements (8, 12) > + if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_LE) > + befs_sb->byte_order = BEFS_BYTESEX_LE; > > WARNING: suspect code indent for conditional statements (8, 12) > + else if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_BE) > + befs_sb->byte_order = BEFS_BYTESEX_BE; > > WARNING: break quoted strings at a space character > + befs_error(sb, "blocksize(%u) cannot be larger" > + "than system pagesize(%lu)", befs_sb->block_size, > > WARNING: line over 80 characters > + if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) { > > Signed-off-by: Luis de Bethencourt > --- > > Fixing these because I was touching this code area. > > Thanks, > Luis > > fs/befs/super.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/fs/befs/super.c b/fs/befs/super.c > index 80b93c0..7c50025 100644 > --- a/fs/befs/super.c > +++ b/fs/befs/super.c > @@ -18,15 +18,15 @@ > * of the befs superblock > */ > int > -befs_load_sb(struct super_block *sb, befs_super_block * disk_sb) > +befs_load_sb(struct super_block *sb, befs_super_block *disk_sb) > { > struct befs_sb_info *befs_sb = BEFS_SB(sb); > > /* Check the byte order of the filesystem */ > if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_LE) > - befs_sb->byte_order = BEFS_BYTESEX_LE; > + befs_sb->byte_order = BEFS_BYTESEX_LE; > else if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_BE) > - befs_sb->byte_order = BEFS_BYTESEX_BE; > + befs_sb->byte_order = BEFS_BYTESEX_BE; > > befs_sb->magic1 = fs32_to_cpu(sb, disk_sb->magic1); > befs_sb->magic2 = fs32_to_cpu(sb, disk_sb->magic2); > @@ -82,7 +82,7 @@ befs_check_sb(struct super_block *sb) > } > > if (befs_sb->block_size > PAGE_SIZE) { > - befs_error(sb, "blocksize(%u) cannot be larger" > + befs_error(sb, "blocksize(%u) cannot be larger " > "than system pagesize(%lu)", befs_sb->block_size, > PAGE_SIZE); > return BEFS_ERR; > @@ -106,10 +106,11 @@ befs_check_sb(struct super_block *sb) > if ((1 << befs_sb->ag_shift) != befs_sb->blocks_per_ag) > befs_error(sb, "ag_shift disagrees with blocks_per_ag."); > > - if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) { > + if (befs_sb->log_start != befs_sb->log_end || > + befs_sb->flags == BEFS_DIRTY) { > befs_error(sb, "Filesystem not clean! There are blocks in the " > - "journal. You must boot into BeOS and mount this volume " > - "to make it clean."); > + "journal. You must boot into BeOS and mount this " > + "volume to make it clean."); > return BEFS_ERR; > } > > -- > 2.5.1 > Signed-off-by: Salah Triki Thanx Salah