From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752258AbcHKAJJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Aug 2016 20:09:09 -0400
Received: from mail-wm0-f49.google.com ([74.125.82.49]:38427 "EHLO
	mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750882AbcHKAJH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Aug 2016 20:09:07 -0400
Date: Thu, 11 Aug 2016 02:09:01 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v2] x86/hweight: fix open-coded versions of 32bit and
 64bit hweight calculations
Message-ID: <20160811000901.GA20255@gmail.com>
References: <alpine.LNX.2.00.1608021357510.22028@cbobk.fhfr.pm>
 <20160802125524.GA6879@twins.programming.kicks-ass.net>
 <20160808102615.GD7141@twins.programming.kicks-ass.net>
 <alpine.LNX.2.00.1608081634530.22028@cbobk.fhfr.pm>
 <alpine.LNX.2.00.1608081808270.22028@cbobk.fhfr.pm>
 <20160810135901.GA22937@gmail.com>
 <alpine.LNX.2.00.1608101604370.22028@cbobk.fhfr.pm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1608101604370.22028@cbobk.fhfr.pm>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jiri Kosina <jikos@kernel.org> wrote:

> On Wed, 10 Aug 2016, Ingo Molnar wrote:
> 
> > >  ENTRY(__sw_hweight64)
> > > -#ifdef CONFIG_X86_64
> > > +
> > 
> > So this removes an #ifdef without removing the #else branch.
> 
> Hi Ingo,
> 
> this patch is obsolete; the real issue has already been fixed by 65ea11ec6 
> ("x86/hweight: Don't clobber %rdi") in Linus' tree already.

Ok, great!

Thanks,

	Ingo