From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932564AbcHKMAm (ORCPT ); Thu, 11 Aug 2016 08:00:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36512 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932233AbcHKMAk (ORCPT ); Thu, 11 Aug 2016 08:00:40 -0400 Date: Thu, 11 Aug 2016 14:00:32 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Michael Petlan Subject: Re: [PATCH] perf tools mem: Fix -t store option for record command Message-ID: <20160811120032.GA18451@krava> References: <1470905457-18311-1-git-send-email-jolsa@kernel.org> <20160811115138.GB27651@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160811115138.GB27651@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 11 Aug 2016 12:00:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu: > > Michael reported 'perf mem -t store record' being broken. > > The reason is latest rework of this area: > > commit acbe613e0c03 ("perf tools: Add monitored events array") > > > > We don't mark perf_mem_events store record when -t store > > option is specified. > > > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array") > ^^^^^^ > I'll remove this extraneous bit well, checkpatch script complained about that when I did not put it there.. but I don't mind ;-) jirka > > > Reported-by: Michael Petlan > > Link: http://lkml.kernel.org/n/tip-dbytnk7urdnnaw7ckdu1w7lq@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/builtin-mem.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c > > index d608a2c9e48c..d1ce29be560e 100644 > > --- a/tools/perf/builtin-mem.c > > +++ b/tools/perf/builtin-mem.c > > @@ -88,6 +88,9 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem) > > if (mem->operation & MEM_OPERATION_LOAD) > > perf_mem_events[PERF_MEM_EVENTS__LOAD].record = true; > > > > + if (mem->operation & MEM_OPERATION_STORE) > > + perf_mem_events[PERF_MEM_EVENTS__STORE].record = true; > > + > > if (perf_mem_events[PERF_MEM_EVENTS__LOAD].record) > > rec_argv[i++] = "-W"; > > > > -- > > 2.4.11