From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbcHKNnC (ORCPT ); Thu, 11 Aug 2016 09:43:02 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56212 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751148AbcHKNnA (ORCPT ); Thu, 11 Aug 2016 09:43:00 -0400 Date: Thu, 11 Aug 2016 15:42:57 +0200 From: Alexandre Belloni To: Daniel Romell Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, daro@hms.se, jao@hms.se, mago@hms.se Subject: Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. Message-ID: <20160811134257.GH8132@piout.net> References: <1470909555-9226-1-git-send-email-daro@hms.se> <1470915104-10683-2-git-send-email-daro@hms.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1470915104-10683-2-git-send-email-daro@hms.se> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2016 at 13:31:43 +0200, Daniel Romell wrote : > From: Jan Östlund > > The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same > value. This is no functional change. > > Signed-off-by: Daniel Romell Sorry, I saw it only before trying apply but both patches also need Jan's SoB. > --- > drivers/rtc/rtc-bq32k.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c > index 0299988..5a0c137 100644 > --- a/drivers/rtc/rtc-bq32k.c > +++ b/drivers/rtc/rtc-bq32k.c > @@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm) > return error; > > tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); > - tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); > + tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); > tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); > tm->tm_mday = bcd2bin(regs.date); > tm->tm_wday = bcd2bin(regs.day) - 1; > -- > 2.7.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com