From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbcHKOJ3 (ORCPT ); Thu, 11 Aug 2016 10:09:29 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34297 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbcHKOJ1 (ORCPT ); Thu, 11 Aug 2016 10:09:27 -0400 Date: Thu, 11 Aug 2016 15:09:19 +0100 From: Salah Triki To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH 1/4] befs: dump inode_size superblock information Message-ID: <20160811140919.GA4140@pc> References: <1470780086-11594-1-git-send-email-luisbg@osg.samsung.com> <20160810214145.GA4372@pc> <57AC4D83.1060305@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57AC4D83.1060305@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 11:03:47AM +0100, Luis de Bethencourt wrote: > On 10/08/16 22:41, Salah Triki wrote: > > On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote: > >> befs_dump_super_block() wasn't giving the inode_size information when > >> dumping all elements of the superblock. Add this element to have complete > >> information of the superblock. > >> > >> Signed-off-by: Luis de Bethencourt > >> --- > >> > >> Hi, > >> > >> This is a series of superblock information related changes. > >> > >> Thanks, > >> Luis > >> > >> fs/befs/debug.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/fs/befs/debug.c b/fs/befs/debug.c > >> index 4de7cff..85c1339 100644 > >> --- a/fs/befs/debug.c > >> +++ b/fs/befs/debug.c > >> @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup) > >> > >> befs_debug(sb, " num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks)); > >> befs_debug(sb, " used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks)); > >> + befs_debug(sb, " inode_size %u", fs32_to_cpu(sb, sup->inode_size)); > >> > >> befs_debug(sb, " magic2 %08x", fs32_to_cpu(sb, sup->magic2)); > >> befs_debug(sb, " blocks_per_ag %u", > >> -- > >> 2.5.1 > >> > > > > Signed-off-by: Salah Triki > > > > Thanx > > Salah > > > > Hi Salah, > > I prefer applying this series as a set. So will wait for your review of patch 2/4. > > Let me know if you don't have time for it. > > Thanks for the reviews, > Luis Hi Luis, I am reviewing the patch 2/4 regards, Salah