From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbcHKOrD (ORCPT ); Thu, 11 Aug 2016 10:47:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:50580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbcHKOrA (ORCPT ); Thu, 11 Aug 2016 10:47:00 -0400 Date: Thu, 11 Aug 2016 11:46:46 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Michael Petlan Subject: Re: [PATCH] perf tools mem: Fix -t store option for record command Message-ID: <20160811144646.GC27651@kernel.org> References: <1470905457-18311-1-git-send-email-jolsa@kernel.org> <20160811115138.GB27651@kernel.org> <20160811120032.GA18451@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160811120032.GA18451@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu: > On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu: > > > Michael reported 'perf mem -t store record' being broken. > > > The reason is latest rework of this area: > > > commit acbe613e0c03 ("perf tools: Add monitored events array") > > > > > > We don't mark perf_mem_events store record when -t store > > > option is specified. > > > > > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array") > > ^^^^^^ > > I'll remove this extraneous bit > > well, checkpatch script complained about that when > I did not put it there.. but I don't mind ;-) Huh? [acme@jouet linux]$ grep Fixes /wb/1.patch Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array") [acme@jouet linux]$ scripts/checkpatch.pl /wb/1.patch total: 0 errors, 0 warnings, 9 lines checked /wb/1.patch has no obvious style problems and is ready for submission. [acme@jouet linux]$ vim /wb/1.patch [acme@jouet linux]$ grep Fixes /wb/1.patch Fixes: acbe613e0c03 ("perf tools: Add monitored events array") [acme@jouet linux]$ scripts/checkpatch.pl /wb/1.patch total: 0 errors, 0 warnings, 9 lines checked /wb/1.patch has no obvious style problems and is ready for submission. [acme@jouet linux]$ - Arnaldo