From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbcHKPG3 (ORCPT ); Thu, 11 Aug 2016 11:06:29 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:33035 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839AbcHKPGZ (ORCPT ); Thu, 11 Aug 2016 11:06:25 -0400 Date: Thu, 11 Aug 2016 12:06:01 -0300 From: Gustavo Padovan To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan Subject: Re: [PATCH v2 1/6] staging/android: remove doc from sw_sync Message-ID: <20160811150601.GE2478@joana> Mail-Followup-To: Gustavo Padovan , Pavel Machek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan References: <1470691462-19140-1-git-send-email-gustavo@padovan.org> <1470691462-19140-2-git-send-email-gustavo@padovan.org> <20160808234139.GD2946@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160808234139.GD2946@xo-6d-61-c0.localdomain> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, 2016-08-09 Pavel Machek : > On Mon 2016-08-08 18:24:17, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > SW_SYNC should never be used by other pieces of the kernel apart from > > sync_debug as it is only a Sync File Validation Framework, so hide any > > info to avoid confuse this with a standard kernel internal API. > > > Signed-off-by: Gustavo Padovan > > NAK. > > It is unclear for what the code does, removing the docs is not going to help. > > If it should not be used, document that it should not be used.. but not remove > the docs. Okay, I'll skip this patch.