From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbcHKNUM (ORCPT ); Thu, 11 Aug 2016 09:20:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:23739 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750780AbcHKNUJ (ORCPT ); Thu, 11 Aug 2016 09:20:09 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: cornelia.huck@de.ibm.com X-IBM-RcptTo: kvm-ppc@vger.kernel.org;kvm@vger.kernel.org;linux-kernel@vger.kernel.org Date: Thu, 11 Aug 2016 15:19:57 +0200 From: Cornelia Huck To: Paolo Bonzini Cc: Paul Mackerras , Alexander Graf , David Gibson , alex.williamson@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, benh@kernel.crashing.org, mpe@ellerman.id.au, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc Subject: Re: [PATCH] vfio: Enable VFIO device for powerpc In-Reply-To: References: <1439428546-13416-1-git-send-email-david@gibson.dropbear.id.au> <55DD8822.4060409@suse.de> <20150826185442.GB2662@fergus.ozlabs.ibm.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081113-0040-0000-0000-0000021120DD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081113-0041-0000-0000-000021544053 Message-Id: <20160811151957.0f113a7c.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-11_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608110179 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Aug 2016 14:57:24 +0200 Paolo Bonzini wrote: > On 26/08/2015 20:54, Paul Mackerras wrote: > > On Wed, Aug 26, 2015 at 11:34:26AM +0200, Alexander Graf wrote: > >> On 13.08.15 03:15, David Gibson wrote: > >>> ec53500f "kvm: Add VFIO device" added a special KVM pseudo-device which is > >>> used to handle any necessary interactions between KVM and VFIO. > >>> > >>> Currently that device is built on x86 and ARM, but not powerpc, although > >>> powerpc does support both KVM and VFIO. This makes things awkward in > >>> userspace > >>> > >>> Currently qemu prints an alarming error message if you attempt to use VFIO > >>> and it can't initialize the KVM VFIO device. We don't want to remove the > >>> warning, because lack of the KVM VFIO device could mean coherency problems > >>> on x86. On powerpc, however, the error is harmless but looks disturbing, > >>> and a test based on host architecture in qemu would be ugly, and break if > >>> we do need the KVM VFIO device for something important in future. > >>> > >>> There's nothing preventing the KVM VFIO device from being built for > >>> powerpc, so this patch turns it on. It won't actually do anything, since > >>> we don't define any of the arch_*() hooks, but it will make qemu happy and > >>> we can extend it in future if we need to. > >>> > >>> Signed-off-by: David Gibson > >>> Reviewed-by: Eric Auger > > This patch (commit 178a787502123) did not select CONFIG_KVM_VFIO, so the > patch did nothing---except causing build failures which I fixed in > commit 0af574be32cdd ("KVM: PPC: do not compile in vfio.o > unconditionally", 2016-03-21) by making the patch a total no-op. > > Is KVM_VFIO really needed, and if so can this patch be fixed? FWIW, we enabled building vfio.o on s390 in 14b0b4a ("KVM: s390: Enable the KVM-VFIO device") with the rationale "while we don't need it, be like everybody else". Should powerpc (and every other architecture supporting kvm and vfio) select KVM_VFIO so that really everybody does the same thing?