From: Sebastian Reichel <sre@kernel.org>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] max17042_battery: fix model download bug.
Date: Fri, 12 Aug 2016 02:59:49 +0200 [thread overview]
Message-ID: <20160812005949.GA8531@earth> (raw)
In-Reply-To: <CAGngYiVv=+RKDcuwqPxyg5GpU6iCBkuR2v7EFmnDM3Xf+w0b_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Sven,
On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
> The device's model download function returns the model data as
> an array of u32s, which is later compared to the reference
> model data. However, since the latter is an array of u16s,
> the comparison does not happen correctly, and model verification
> fails. This in turn breaks the POR initialization sequence.
It looks like your mail software broke the patch format.
Applying: max17042_battery: fix model download bug.
fatal: corrupt patch at line 10
Patch failed at 0001 max17042_battery: fix model download bug.
I can see, that at least the tabs were replaced with spaces. Please
send again with this fixed and while you touch the patch anyways add
the the tags Krzysztof and I mentioned in this thread.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-12 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 14:03 [PATCH] max17042_battery: fix model download bug Sven Van Asbroeck
2016-08-09 18:54 ` Sebastian Reichel
2016-08-10 8:27 ` Krzysztof Kozlowski
2016-08-12 0:59 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812005949.GA8531@earth \
--to=sre@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox