From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbcHLA75 (ORCPT ); Thu, 11 Aug 2016 20:59:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:55346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHLA7z (ORCPT ); Thu, 11 Aug 2016 20:59:55 -0400 Date: Fri, 12 Aug 2016 02:59:49 +0200 From: Sebastian Reichel To: Sven Van Asbroeck Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] max17042_battery: fix model download bug. Message-ID: <20160812005949.GA8531@earth> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sven, On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote: > The device's model download function returns the model data as > an array of u32s, which is later compared to the reference > model data. However, since the latter is an array of u16s, > the comparison does not happen correctly, and model verification > fails. This in turn breaks the POR initialization sequence. It looks like your mail software broke the patch format. Applying: max17042_battery: fix model download bug. fatal: corrupt patch at line 10 Patch failed at 0001 max17042_battery: fix model download bug. I can see, that at least the tabs were replaced with spaces. Please send again with this fixed and while you touch the patch anyways add the the tags Krzysztof and I mentioned in this thread. -- Sebastian --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXrR+CAAoJENju1/PIO/qa41UQAIKA3jciwjgNtFTN0zGyOLpp GokZmq7o6k+69qyJRUnEFU9C+B2wEbMK8gQqysElpaA20Lqoq4DkSWJ0YJErKH8t ec9VAjaKkN6XlLZWWE3xIqFDRD9wLr+i3/H2YgDwG3R1XPAw7Ugi+Xvfz6Bv1Yn+ qvOoFcD3x6MJ84HJTt/R27qZoRtoX/SyDhAL0DDKHHg1NJgTIhBW/BuPPMU0rvLH VP5qjo0N2LpvBHBHHC/AHUT7fKlFyhDindq186UF6lwqPPahDMZrnP1aFjikiCfm hP0m2CUHqPBiGB6Qfp1tXwcIj136YYHvZewbeIrnJIVczaY9oeqiMvPPA5vEKIC4 hwd0O9hYYNAsqFoi7DDvc3D9tUcFhojmu1bBYZZCIadd+fQxigAWc6Bf8+4gi6OP byIe63ZP2Ph4ksE8gr+xXECLrUFim6h0jEF+RTp8jTIZzPLzYofog+YC7h0I3pAQ RpJNpqVVIuCLMk6bFfM0R2qRF9W+kiu3Ql3OuqoffV6HfNCUjUAVE0PKFd9cnw8G Dv8UyWnHxDV0YbrE9LdXLMyw2Phctc6SIuK345Rz/yWI9XyJO3UEBA92553Tn/TF l7HTaBJfz95zqL6C72IGHRXk82JDwKxIEMMyhA8AsqRrmUKxdBGtkRk1PEZ/eP/5 iQsHouO1idNmrPe/1i6n =F6RO -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--