public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, acme@kernel.org,
	adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
	hekuang@huawei.com, jolsa@kernel.org, mingo@redhat.com,
	peterz@infradead.org, wangnan0@huawei.com
Subject: Re: [RFCv3 2/2] perf: util: support sysfs supported_cpumask file
Date: Fri, 12 Aug 2016 12:01:23 +0200	[thread overview]
Message-ID: <20160812100123.GB25813@krava> (raw)
In-Reply-To: <1470933366-1364-3-git-send-email-mark.rutland@arm.com>

On Thu, Aug 11, 2016 at 05:36:06PM +0100, Mark Rutland wrote:
> The perf tools can read a cpumask file for a PMU, describing a subset of
> CPUs which that PMU covers. So far this has only been used to cater for
> uncore PMUs, which in practice happen to only have a single CPU
> described in the mask.
> 
> Until recently, the perf tools only correctly handled cpumask containing
> a single CPU, and only when monitoring in system-wide mode. For example,
> prior to commit 00e727bb389359c8 ("perf stat: Balance opening and
> reading events"), a mask with more than a single CPU could cause
> perf stat to hang. When a CPU PMU covers a subset of CPUs, but lacks a
> cpumask, perf record will fail to open events (on the cores the PMU does
> not support), and gives up.
> 
> For systems with heterogeneous CPUs such as ARM big.LITTLE systems, this
> presents a problem. We have a PMU for each microarchitecture (e.g. a big
> PMU and a little PMU), and would like to expose a cpumask for each (so
> as to allow perf record and other tools to do the right thing). However,
> doing so kernel-side will cause old perf binaries to not function (e.g.
> hitting the issue solved by 00e727bb389359c8), and thus commits the
> cardinal sin of breaking (existing) userspace.
> 
> To address this chicken-and-egg problem, this patch adds support got a
> new file, supported_cpumask, which is largely identical to the existing
> cpumask file. A kernel can expose this file, knowing that new perf
> binaries will correctly support it, while old perf binaries will not
> look for it (and thus will not be broken).

I might have asked before, but what's the kernel side state of this?

thanks,
jirka

  reply	other threads:[~2016-08-12 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 16:36 [RFCv3 0/2] perf tools: play nicely with CPU PMU cpumasks Mark Rutland
2016-08-11 16:36 ` [RFCv3 1/2] perf: util: only open events on CPUs an evsel permits Mark Rutland
2016-08-11 16:36 ` [RFCv3 2/2] perf: util: support sysfs supported_cpumask file Mark Rutland
2016-08-12 10:01   ` Jiri Olsa [this message]
2016-08-31 10:46     ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812100123.GB25813@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox