Re: [PART2 PATCH v5 12/12] svm: Implements update_pi_irte hook to setup posted interrupt

Suravee Suthikulpanit
2016-08-19T01:19:19Z

Hi Radim,

On 8/16/16 23:33, Radim Krčmář wrote:
>>> Maybe I was a bit confused by reusing amd_iommu_pi_data when all we care
>>> >> about is a list of cur->ir_data -- can't we have a list of just ir_data?
>> >
>> > Actually, in SVM, we care about posted-interrupt information, which is
>> > generated from the SVM side, and stored in the amd_iommu_pi_data. This is
>> > also communicated to IOMMU via the irq_set_vcpu_affinity().
>> >
>> > Here, I only use ir_data to differentiate amd_iommu_pi_data.
> I'm still confused then. :)
>
> struct amd_iommu_pi_data is a throwaway structure for I/O with
> irq_set_vcpu_affinity(), but we keep it afterwards ...
> is it more than a wrapper that allows us to put ir_data into a list,
> because we don't want to add list_head directly to ir_data?

Hm... I see you point now. I'll change it to ir_data list.

Thanks,
Suraveee