Re: [linux-sunxi] [PATCH RFC 3/3] ARM: dts: sun8i: add hwspinlock device to sun8i-h3

Hans de Goede
2016-08-12T11:49:30Z

Hi,

On 12-08-16 13:46, LABBE Corentin wrote:
> Add the hwspinlock device tree node for the device present on H3.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 439e8ed..c801389 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -489,6 +489,16 @@
> status = "disabled";
> };
>
> + hwspinlock: hwspinlock@1c18000 {
> + compatible = "allwinner,sun8i-hwspinlock";
> + reg = <0x01c18000 0x400>;
> + resets = <&ccu RST_BUS_SPINLOCK>;
> + reset-names = "ahb";
> + clocks = <&ccu CLK_BUS_SPINLOCK>;
> + clock-names = "ahb";
> + status = "disabled";
> + };
> +
> gic: interrupt-controller@01c81000 {
> compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic";
> reg = <0x01c81000 0x1000>,
>

Why status=disabled? If this is a core part of the SoC, which Linux
can use, then IMHO it should be always enabled, like e.g. we also
always enable the timers.

Regards,

Habs